Repository navigation
Compose explicit reviewer service startup and retained shutdown - #228
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
🔵 Needs a closer look
Broad lifecycle and native runtime changes warrant final human review.
No open issues 🎉
What changed in this PR
Adds a private Linux reviewer service with explicit credential qualification, native runtime selection, polling, and ordered shutdown ownership.
Changes:
- Adds service startup, recovery, refresh, run, and close lifecycle handling.
- Adds bounded native release/provider catalog composition.
- Documents ownership and lifecycle guarantees with focused tests.
| File | Description |
|---|---|
reviewer/GIT-SERVICE.md |
Documents service ownership and lifecycle rules. |
reviewer/git_service_runtime_linux.go |
Builds validated native runtimes. |
reviewer/git_service_runtime_linux_test.go |
Tests catalog binding and runtime isolation. |
reviewer/git_service_linux.go |
Implements service orchestration and shutdown. |
reviewer/git_service_linux_test.go |
Tests lifecycle and ownership behavior. |
Review effort: Lite
045a844 to
34c6f44
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The source factory and credential/controller libraries had no service owner to retain them together. This private Linux assembly recovers source before explicit credential qualification, polls the selected comment and automatic triggers, and joins the controller before releasing source or credential owners.
The native release catalog selects each durable job's original release and configured providers, with a separate bound reader and audited VM reviewer for each provider. Construction performs no signing, GitHub request, auth import or inference.
Acceptance criteria
Validation
The child-owned commit was rebased onto the actual PR #227 squash merge. Its entire tree
076359a188710b1cbf8716997cb36a841c7aab44is identical to tested head045a844df2566d9c9821c69e374ce15126e50b54; the local qualification below is retained for those unchanged bytes. New-head Codex review is still required.Head
34c6f4422123d56d7a32a9eb43a0414849d6b1cf.go -C reviewer vet ./...: PASS.go test -race -run 'TestGitReviewerService|TestGitServiceNative' -count=1 ./...: PASS, main package 1.958 seconds.SFL_GIT_DESCRIPTOR_KERNEL=1 SFL_GIT_BOOTSTRAP_NAMESPACE=1 go -C reviewer test -race -count=1 ./...: PASS, main package 172.014 seconds.Definition of done and limits
This is one source slice of #176, built on the acquisition factory merged in #227. It does not close the broader issue. The internal service has no public operator entry point or deployment packaging yet. Trusted release promotion/rollback, native control tasks and the durable evaluation runner remain source work.
reviewer/GIT-SERVICE.mdrecords ownership and lifecycle rules.Complete host containment qualification, provider policy/account/quota evidence, final App/trigger rendering proof and explicit live owner authorization remain separate gates. Prior physical qualification failures remain failures. Actions is disabled by owner; no CI result or live activation is claimed.